New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build out list of all vanilla WordPress “blocks” and their AMP compatibility #806

Closed
westonruter opened this Issue Nov 16, 2017 · 11 comments

Comments

Projects
6 participants
@westonruter
Member

westonruter commented Nov 16, 2017

[Edited] Refer to the latest acceptance criteria.


We want to ensure that if you have AMP installed as the sole plugin in a WordPress install that everything you can do in a vanilla WordPress site is compatible with AMP: every embed that a user can add to a post, every inserted media, every widget added to a sidebar, and even the various template parts that WordPress outputs (e.g. wp_nav_menu(), get_search_form(), and comments_template()). This can be paired with Theme Unit Test sample data and validation checklists.

If we do this right, we can then incorporate the test data into the build process to make sure that we don't break AMP compatibility with anything WordPress does.

This will also need to be done for Gutenberg blocks.

@ThierryA ThierryA added this to To Do in v0.6 via automation Nov 27, 2017

@ThierryA ThierryA moved this from To Do to Definition in v0.6 Nov 27, 2017

@MackenzieHartung MackenzieHartung moved this from Definition to To Do in v0.6 Nov 27, 2017

@ThierryA ThierryA moved this from To Do to Definition in v0.6 Nov 27, 2017

@MackenzieHartung

This comment has been minimized.

MackenzieHartung commented Dec 4, 2017

Acceptance Criteria

  1. Anything that WordPress allows to be input into post content, regarding embeds, should be supported by AMP.
  2. Generate a list of all embeds that exist within WordPress (out of the box experience).
  3. Verify which of the embed types work in AMP, somewhat work in AMP, or do not work in AMP.

@MackenzieHartung MackenzieHartung moved this from Definition to To Do in v0.6 Dec 4, 2017

@ThierryA ThierryA moved this from To Do to In Progress in v0.6 Dec 11, 2017

@ThierryA ThierryA self-assigned this Dec 11, 2017

@ThierryA

This comment has been minimized.

Collaborator

ThierryA commented Dec 11, 2017

AMP Support

Update: this list is now updated, and located in the project wiki

Below is a list of the AMP support for WP Vanilla content

AMP Support Status Note
Caption
Media Gallery
Media Image
Media Video playlist
Media Audio playlist
Media Video
Media Audio
Post Embed 🔸 See #809 for improvements.
Amazon Embed
Animoto Video Embed
Cloudup Image Embed
Cloudup Video Embed
CollegeHumor Video Embed 🔸 Partial support, video player appears but doesn't play
DailyMotion Video Embed
Facebook Post Embed
Facebook Video Embed
Flickr Image Embed
Flickr Video Embed
Funny Or Die Video Embed
Instagram Embed
Issuu Embed
Kickstarter Embed
MeetUp Embed 🔸 Markup appears, but there's no styling like on the WordPress page. This was applied to the element #meetup_oembed.
Mixcloud Embed
Polldaddy Embed Support fixed in #829. Only link is shown.
Reddit Embed 🔸 Some markup appears, but without styling
ReverbNation Embed
Screencast Embed 🔸 Displays "Unable to display content. Adobe Flash is required," even with the domain added to Chrome's Flash "Allow" list.
Scribd Embed
SlideShare Embed
SmugMug Embed
Someecards Embed
SoundCloud Embed Support fixed in #829.
Speaker Deck Embed
Spotify Embed
Ted Embed
Tumblr Embed 🔸 Only shows the link.
Twitter Embed
VideoPress Embed
Vimeo Embed
WordPress Plugin Directory Embed 🔸 Appears mainly as expected, but with slightly different styling and an extra link
WordPress.tv Embed
YouTube Embed
@kienstra

This comment has been minimized.

Collaborator

kienstra commented Dec 13, 2017

Supported Embed Types

Hi @ThierryA,
Your comment above shows whether most of WordPress's supported embeds render properly in AMP.

There are some embeds that don't even render in a standard WordPress page, like Scribd and Photobucket.

And @westonruter's pull request has the wp-cli script to create a test page with those embeds and media types.

@kienstra kienstra assigned ThierryA and unassigned ThierryA and kienstra Dec 13, 2017

@ThierryA ThierryA moved this from In Progress to Ready for Review in v0.6 Dec 13, 2017

@westonruter westonruter added this to the v0.6 milestone Dec 13, 2017

@westonruter

This comment has been minimized.

Member

westonruter commented Dec 14, 2017

@kienstra It looks like some of the oEmbed providers aren't all listed yet. I'm looking at the list here: https://github.com/WordPress/wordpress-develop/blob/c6326694380722ccbdd78e21a2bd0d079383291c/src/wp-includes/class-oembed.php#L54-L119

I don't see animoto, speakerdeck, or amazon for example. Could you please make sure every oEmbed is included in the list and in the test data?

@kienstra

This comment has been minimized.

Collaborator

kienstra commented Dec 14, 2017

Will Add Missing oEmbed URLS

Hi @westonruter,
Sure, I'll add the missing oEmbed URLs tomorrow (Thursday) if that's alright.

@westonruter westonruter moved this from Ready for Review to QA in v0.6 Dec 15, 2017

@westonruter

This comment has been minimized.

Member

westonruter commented Dec 15, 2017

Deployed changes to the testbed site and created test page with embeds:

Non-AMP: http://amp-xwp-testbed.pantheonsite.io/amp-test-embeds/
AMP: http://amp-xwp-testbed.pantheonsite.io/amp-test-embeds/?amp

@csossi csossi moved this from QA to Ready for Merging in v0.6 Dec 18, 2017

@ahmadawais

This comment has been minimized.

ahmadawais commented Jan 12, 2018

@ThierryA it would be great to have that AMP Support table there on the README.md or in a AMP-SUPPORT.md what do you think?

Also excited about this enhancement.

@ThierryA

This comment has been minimized.

Collaborator

ThierryA commented Jan 12, 2018

Thanks for your suggestion @ahmadawais, a wiki page would probably be the best place for that. The readme is already pretty long and we plan to do more "Vanilla WordPress Support" discovery such as widgets etc.

@westonruter

This comment has been minimized.

Member

westonruter commented Jan 12, 2018

The wiki is easier to update on an ongoing basis as well.

@ahmadawais

This comment has been minimized.

ahmadawais commented Jan 12, 2018

Right about that. Works for me.

@kienstra

This comment has been minimized.

Collaborator

kienstra commented Mar 12, 2018

Wiki Page

Hi @ahmadawais and @westonruter,
Here's the wiki page that shows widget and embed support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment