Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate spec import to new location docs/spec #5821

Open
sebastianbenz opened this issue May 12, 2021 · 2 comments
Open

Migrate spec import to new location docs/spec #5821

sebastianbenz opened this issue May 12, 2021 · 2 comments
Assignees

Comments

@sebastianbenz
Copy link
Collaborator

Once ampproject/amphtml#34160 has landed. We probably should import all docs from master to avoid syncing the change with the next amp release.

@patrickkettner
Copy link
Collaborator

@sebastianbenz just to be sure - by master do you mean main?

@sebastianbenz
Copy link
Collaborator Author

Yes, but the parameter is still named master in our code. BTW, we're already defaulting to main for the spec import, so we should be fine: https://github.com/ampproject/amp.dev/blob/future/platform/lib/pipeline/specImporter.js#L51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants