Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cookie support #451

Open
patrickkettner opened this issue Apr 21, 2019 · 5 comments
Open

cookie support #451

patrickkettner opened this issue Apr 21, 2019 · 5 comments
Assignees
Labels
API Something is missing or broken in the API surface

Comments

@patrickkettner
Copy link
Collaborator

A (sadly) very common pattern for user auth is to rely on cookies for state. As a result, sites need to be able to know up to the moment information about the cookie store, that may be modified in other browser windows (ie multitab). Many major websites need to be aware of cookie jar modifications in other windows (either by rapidly polling document.cookie for changes, or via the Cookie Store API. amp-script/worker dom introduce some really exciting opportunities for component reuse, but in order for that to be possible to many of these authors, we would need to provide a cookie interface, and one that isn’t just a snapshot of the cookie jar on hydration

@patrickkettner
Copy link
Collaborator Author

(This is a follow up to a conversation at ampconf- cc @kristoferbaxter @nainar )

@ngocdb
Copy link

ngocdb commented May 13, 2019

+1 vote for the feature. We really really need it.

@kristoferbaxter
Copy link
Contributor

Plan of attack:

  1. Leverage Cookie Store API.
  2. Create a Polyfill that's lazily loaded and configurable with a different polling interval.

@kristoferbaxter kristoferbaxter self-assigned this May 24, 2019
@dreamofabear dreamofabear added the API Something is missing or broken in the API surface label Jul 9, 2019
@morsssss
Copy link
Contributor

I'd love to see this happen, especially as we're considering making this possible in traditional AMP components in ampproject/amphtml#25670.

@kristoferbaxter wdyt?

@diffidentDude
Copy link

This would be great, additionally it would be nice if it could be scoped so we don't need to worry about cross app cookie overlap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Something is missing or broken in the API surface
Projects
None yet
Development

No branches or pull requests

6 participants