-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is absolute_expiry_time
in milliseconds?
#403
Comments
absolute_expiry_time
in milliseconds?
Yes, though you can set it to a javascript Date object. |
great, thank you! closing this issue for now, but I do think it'd be useful to specify that somewhere such as in the typescript comment. At least for now, someone can search github issues for this answer. |
Also, is setting it to a JavaScript date object supported in 1.0.24? The typescript for that version says |
I believe so as the tests use the typescript interface: e.g. https://github.com/amqp/rhea/blob/main/test/messages.ts#L247 |
From my understanding of the commit history, it seems like the corresponding test for 1.0.24 do not use a JavaScript Date object. Here is a link to the test at the commit where the package.json version was bumped to 1.0.24: Could you clarify what the implication of this is in terms of Date object support on this specific version (1.0.24)? I just want to make sure we are using rhea correctly in production. Thanks again! |
Yes, you are correct that support for setting it as a Date object is not available on 1.0.2, where you must set it as the millisecs from epoch (i.e. the value returned by getTime() on the date object). |
Great, thank you! |
Hello, I am using rhea version 1.0.24.
For the
absolute_expiry_time
message property, should we be setting to milliseconds since epoch? Apologies if this is supposed to be obvious—I am not able to find an answer looking though the repo. Thanks!The text was updated successfully, but these errors were encountered: