Convert to Swift4.2 syntax & Xcode10 project. #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arnings_about_syntax
amratab
reviewed
Jan 2, 2019
| <layoutGuides> | ||
| <viewControllerLayoutGuide type="top" id="jyV-Pf-zRb"/> | ||
| <viewControllerLayoutGuide type="bottom" id="2fi-mo-0CV"/> | ||
| </layoutGuides> | ||
| <view key="view" contentMode="scaleToFill" id="kh9-bI-dsS"> | ||
| <rect key="frame" x="0.0" y="0.0" width="600" height="600"/> | ||
| <rect key="frame" x="0.0" y="0.0" width="375" height="667"/> |
There was a problem hiding this comment.
oh, sorry... Main.storyboard changes is not required.
I will revert any Main.storyboard changes.
There was a problem hiding this comment.
I fixed e01ab3b.
amratab
reviewed
Jan 2, 2019
| </dependencies> | ||
| <scenes> | ||
| <!--View Controller--> | ||
| <scene sceneID="ufC-wZ-h7g"> | ||
| <objects> | ||
| <viewController id="vXZ-lx-hvc" customClass="ViewController" customModuleProvider="target" sceneMemberID="viewController"> | ||
| <viewController id="vXZ-lx-hvc" customClass="ViewController" customModule="FlexibleSteppedProgressBar_Example" customModuleProvider="target" sceneMemberID="viewController"> |
|
Can you please fix the circle ci failures also by modifying the circleci config file? |
|
@amratab |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this master branch is behind in the latest version.
So I convert Swift4.2 syntax & adopt to Xcode10 or above.
Examples:
UIApplicationLaunchOptionsKey→UIApplication.LaunchOptionsKeyUIViewContentMode.redraw→UIView.ContentMode.redrawNSAttributedStringKey→NSAttributedString.KeykCAMediaTimingFunctionEaseInEaseOut→AMediaTimingFunctionName.easeInEaseOutUIGestureRecognizerState.ended→UIGestureRecognizer.State.endedThanks.