Math Magicians: Events #3
Conversation
There was a problem hiding this comment.
Hi @amrendrakind ,
Good job so far! 👍
There are some issues that you still need to work on to go to the next project but you are almost there!
Required Changes ♻️
- Please check the inline comments under the review. ⬇️
To Highlights
✔️ No linter errors.
✔️ Good README.
✔️ Descriptive PR title & description.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification. You can also reach me on slack
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
src/logic/Operate.js
Outdated
| if (operation === '%') { | ||
| try { | ||
| return (one.times(two).div(100)).toString(); | ||
| } catch (err) { | ||
| return "Can't find modulo as can't divide by 0."; | ||
| } | ||
| } |
There was a problem hiding this comment.
-
The
%button should work as a modulus, not as a percentage. If I calculate17 %(mod) 5the output should be2but currently, it shows.85. Kindly fix the issue. -
The arithmetic operators
('+', '-', '/' etc.)of your calculator are working but it is not showing on the display. Whenever you click on any arithmetic operators, It should be displayed on the calculator display.
There was a problem hiding this comment.
Hi @amrendrakind,
Your project is complete! There is nothing else to say other than... it's time to merge it 
Status: Approved ✔️✔️✔️
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Events