Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Math Magicians: Full Website #5

Merged
merged 14 commits into from May 5, 2022
Merged

Math Magicians: Full Website #5

merged 14 commits into from May 5, 2022

Conversation

amrendrakind
Copy link
Owner

@amrendrakind amrendrakind commented May 5, 2022

Math Magicians: Full Website

  • Create a website consisting of 3 pages: Home, Calculator, and Quote.
  • Add your own styles to improve the look and feel.
    • In this project, you should use React basic styling.
  • For every page, you should create a route.
  • Make sure that navigation links for all 3 routes are displayed on each page.
  • Use React Router to make the routes work.
  • Deployed math-magicians

Copy link

@nicupop729 nicupop729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @amrendrakind ,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

  • Correct git flow practice ✔️
  • Good commit messages ✔️
  • Professional README ✔️
  • Linters are passing ✔️
  • Clean codebase ✔️

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@amrendrakind
Copy link
Owner Author

@nicupop729 Thank you 🤗

@amrendrakind amrendrakind merged commit 63f9c7b into dev May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants