Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drive_initial_convection not fully implemented #383

Open
zingale opened this issue May 10, 2023 · 1 comment
Open

drive_initial_convection not fully implemented #383

zingale opened this issue May 10, 2023 · 1 comment

Comments

@zingale
Copy link
Member

zingale commented May 10, 2023

There seems to be a few issues with drive_initial_convection:

  • We never implemented stop_initial_convection, even though that parameter exists in _cpp_parameters
  • We should use the new burn_t.T_fixed field to pass in the fixed temperature for the burning
@zingale
Copy link
Member Author

zingale commented May 10, 2023

  • restart_with_vel_field is also never used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zingale