-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
burning_cutoff_density is too high by default #64
Comments
One could make this argument for all the cutoff densities. Perhaps we should force the user to set these by having the default be -1, and abort if it's not set in the inputs file. |
I like that idea. |
There is |
In the original MAESTRO, the error checking to make sure the inputs files didn't have nonsensical values was in |
I'm thinking |
Those sound good to me - they're the ones I had issues with for the massive star (in that I didn't realise that the cutoff parameters existed or that they were set to values that were so high for this problem). |
Implemented and merged in from cutoff_cleanup branch. renname anelastic_cutoff -> anelastic_cutoff_density require anelastic and base_cutoff_density to be supplied in the inputs file - code aborts if not supplied burning_cutoff_density takes on the value of base_cutoff_density if not supplied in the inputs file all inputs files updated to retain the old defaults (3.e6) if nothing was supplied |
The default value of
burning_cutoff_density
is 3.e6 (g/cc). This reflects Maestro's origin as a code for modeling burning in WDs, but for other applications users may be unaware of this cutoff. We should have this off by default (set it to 0.0 as in Castro). This point of this parameter is optimization, just to skip the burn in regions where it shouldn't matter.The text was updated successfully, but these errors were encountered: