Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

burning_cutoff_density is too high by default #64

Closed
zingale opened this issue Apr 30, 2019 · 7 comments
Closed

burning_cutoff_density is too high by default #64

zingale opened this issue Apr 30, 2019 · 7 comments
Assignees

Comments

@zingale
Copy link
Member

zingale commented Apr 30, 2019

The default value of burning_cutoff_density is 3.e6 (g/cc). This reflects Maestro's origin as a code for modeling burning in WDs, but for other applications users may be unaware of this cutoff. We should have this off by default (set it to 0.0 as in Castro). This point of this parameter is optimization, just to skip the burn in regions where it shouldn't matter.

@ajnonaka
Copy link
Contributor

One could make this argument for all the cutoff densities. Perhaps we should force the user to set these by having the default be -1, and abort if it's not set in the inputs file.

@zingale
Copy link
Member Author

zingale commented Apr 30, 2019

I like that idea.

@ajnonaka
Copy link
Contributor

There is base_cutoff_density, anelastic_cutoff, and burning_cutoff_density that should have this behavior. (aesthetically we should call it anelastic_cutoff_density instead) There is also a buoyancy_cutoff_factor but I think the default of 5 can be kept for that.

@ajnonaka ajnonaka self-assigned this Apr 30, 2019
@ajnonaka
Copy link
Contributor

In the original MAESTRO, the error checking to make sure the inputs files didn't have nonsensical values was in probin.template. Wondering where to put the equivalent statements in MAESTROeX. Maybe in meth_params.template at the end of read_method_params...?

@ajnonaka
Copy link
Contributor

I'm thinking base and anelastic cutoff should be required in the inputs file. burning, if not supplied, will be set to base (this is what original MAESTRO did). Any objections? (it's easy to change later)

@harpolea
Copy link
Member

Those sound good to me - they're the ones I had issues with for the massive star (in that I didn't realise that the cutoff parameters existed or that they were set to values that were so high for this problem).

@ajnonaka
Copy link
Contributor

Implemented and merged in from cutoff_cleanup branch.

renname anelastic_cutoff -> anelastic_cutoff_density

require anelastic and base_cutoff_density to be supplied in the inputs file - code aborts if not supplied

burning_cutoff_density takes on the value of base_cutoff_density if not supplied in the inputs file

all inputs files updated to retain the old defaults (3.e6) if nothing was supplied

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants