Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we drop 1-d support #86

Closed
zingale opened this issue Aug 6, 2019 · 1 comment
Closed

Should we drop 1-d support #86

zingale opened this issue Aug 6, 2019 · 1 comment

Comments

@zingale
Copy link
Member

zingale commented Aug 6, 2019

Support for 1-d problems was added to original Maestro to allow us to model smallscale flames. In the original Bell et al. 2004 low Mach algorithm we used for flames, we never had 1-d -- we just ran flames in long, narrow 2-d domains if we were just interested in the laminar properties.

1-d doesn't really make sense for atmospheric flows.

So I would propose that we remove 1-d support from MAESTROeX. We can still do smallscale flames in 2-d if needed (and this is not any user's science priority at the moment).

@ajnonaka
Copy link
Contributor

ajnonaka commented Aug 6, 2019

I am fine with eliminating 1-d support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants