Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

variable length array in table_rates.H #1261

Closed
zingale opened this issue Jul 6, 2023 · 2 comments · Fixed by pynucastro/pynucastro#567
Closed

variable length array in table_rates.H #1261

zingale opened this issue Jul 6, 2023 · 2 comments · Fixed by pynucastro/pynucastro#567

Comments

@zingale
Copy link
Member

zingale commented Jul 6, 2023

For pynucastro nets, we do:

    Real ldata[tf.nvars+2];

The HIP compiler complains about this, since tf.nvars is not known until runtime. We should switch to something else here.
@zingale zingale mentioned this issue Jul 13, 2023
Merged
@yut23
Copy link
Collaborator

yut23 commented Jul 13, 2023

Can we just read directly into the data arrays?

@zingale
Copy link
Member Author

zingale commented Jul 13, 2023

yeah, I think you are right. We should just rewrite this.

@yut23 yut23 mentioned this issue Jul 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rework init_tab_info() to avoid a VLA yut23/pynucastro
2 participants
@yut23 @zingale