-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
speed up chabrier1998 screening by adding `` entries #1396
Comments
The quantum correction terms also use a lot of pows, which we should probably switch to nested evaluation like in screen5. |
I'm actually debating on whether those terms are needed. These quantum correction terms were not in the original chabrier&potekhin paper. They were introduced in Calder's paper, so I added them. Removing them might give better convergence with NSE states too, although I never tested it. |
added a runtime parameter to make quantum correction terms in chabrier1998 screening optional. This is because in NSE_solver quantum terms are not included. Also fixed some inconsistent indentations This should also speed up this screening a little bit (issue #1396), although we already switched integer pows to powi.
I think that this has been addressed now |
Currently, in
chabrier1998
, we do:we should move these pow's into
screen_factors_t
, perhaps only enabled if we are using this screening routine. This will save on a lot of expensive powsThe text was updated successfully, but these errors were encountered: