Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need to reevaluate the tolerances #20

Closed
zingale opened this issue Nov 8, 2016 · 6 comments
Closed

need to reevaluate the tolerances #20

zingale opened this issue Nov 8, 2016 · 6 comments

Comments

@zingale
Copy link
Member

zingale commented Nov 8, 2016

We ask for species to be evolved to a tolerance of 1.d-12 (in integration/_parameters).

This is pretty tight. We need to check whether it can be relaxed. We can relax on a network-by-network basis (using priorities in the _parameter files).

It seems that the original aprox13 and aprox19 networks used tolerances of 1.e-6

@zingale
Copy link
Member Author

zingale commented Nov 8, 2016

note also that the BS integrator has only a single tolerance -- it takes the max of all the tolerances:

    bs % atol(:) = 0.d0                                                         
    bs % rtol(:) = max(rtol_spec, rtol_temp, rtol_enuc)                         

@zingale
Copy link
Member Author

zingale commented Nov 9, 2016

the way to properly do this is to look at convergence of the results as we tighten the tolerances for each burner / integrator.

@zingale
Copy link
Member Author

zingale commented Jul 25, 2017

there is some thought on this in the wdmerger II paper. It seems that 1.e-8 should be okay...

@zingale
Copy link
Member Author

zingale commented Apr 9, 2018

I think that @abigailbishop largely has done this. We should add some plots to the user's guide

@abigailbishop
Copy link
Contributor

I can do that.

@zingale
Copy link
Member Author

zingale commented Sep 10, 2021

I think we've mostly addressed this now.

@zingale zingale closed this as completed Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants