-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
need to reevaluate the tolerances #20
Comments
note also that the
|
the way to properly do this is to look at convergence of the results as we tighten the tolerances for each burner / integrator. |
there is some thought on this in the wdmerger II paper. It seems that 1.e-8 should be okay... |
I think that @abigailbishop largely has done this. We should add some plots to the user's guide |
I can do that. |
I think we've mostly addressed this now. |
We ask for species to be evolved to a tolerance of 1.d-12 (in
integration/_parameters
).This is pretty tight. We need to check whether it can be relaxed. We can relax on a network-by-network basis (using priorities in the
_parameter
files).It seems that the original aprox13 and aprox19 networks used tolerances of 1.e-6
The text was updated successfully, but these errors were encountered: