Faraday 1.x.x compability

[ayanko]

https://github.com/lostisland/faraday/blob/master/UPGRADING.md

So we need on

https://github.com/amro/gibbon/blob/master/lib/gibbon/api_request.rb#L112

-   if error.is_a?(Faraday::ClientError) && error.response
+   if (error.is_a?(Faraday::ClientError) || error.is_a?(Faraday::ServerError) ) && error.response

[amro]

Thanks very much for pointing this out. I can take a look and test this on Friday

…

On Mar 8, 2021, at 1:16 PM, Andriy Yanko ***@***.***> wrote:  https://github.com/lostisland/faraday/blob/master/UPGRADING.md So we need on https://github.com/amro/gibbon/blob/master/lib/gibbon/api_request.rb#L112 - if error.is_a?(Faraday::ClientError) && error.response + if (error.is_a?(Faraday::ClientError) || error.is_a?(Faraday::ServerError) ) && error.response — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[amro]

Thanks again for the callout and contribution @ayanko. I've just released Gibbon 3.4.0 w/ your change in place to address this. I did need to make some minor config changes to accommodate testing Ruby 3.0.0 on CI.