WIP: Add comments with type for exports #46
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a little experiment, but it would be nice to be able to enable something like this in the output.
TypedModule
(frominfer
) tocompile
, so type info becomes accessible(exp.value.info as any).type
to get the type of an expression, because we do not have an explicitNode<Untyped>
yet.estree
types are not fully compatible withrecast
, in particular the comments work differently. Whereestree
expectsleadingComments: []
andtrailingComments: []
on theExpression
itself,recast
uses acomments: []
fields and checks for aleading
ortrailing
flag inside theComment
(so someas JS.ExpressionStatement
hacks were needed).Result is that
compiles to