Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prettyPrinter string identity test (after stripping spaces) #67

Merged
merged 2 commits into from Mar 24, 2019

Conversation

tkers
Copy link
Member

@tkers tkers commented Mar 24, 2019

Adds some test cases ensuring that the prettyPrinter only modifies spaces/newlines, not the notation of the input code.

This currently fails for

  • Partial type annotations: _ is transformed into __t1
  • At-expressions: @foo{...} is transformed into (foo ...)

@codecov
Copy link

codecov bot commented Mar 24, 2019

Codecov Report

Merging #67 into master will increase coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
+ Coverage    89.8%   90.02%   +0.21%     
==========================================
  Files          30       30              
  Lines        1393     1393              
  Branches      217      217              
==========================================
+ Hits         1251     1254       +3     
+ Misses        121      119       -2     
+ Partials       21       20       -1
Impacted Files Coverage Δ
packages/delisp-core/src/printer.ts 100% <0%> (+6.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 896115f...4f26e45. Read the comment docs.

@davazp
Copy link
Member

davazp commented Mar 24, 2019

Looks good!

@tkers tkers marked this pull request as ready for review March 24, 2019 18:04
@tkers
Copy link
Member Author

tkers commented Mar 24, 2019

Merging this and adding issues for the 2 test cases that are currently skipped.

@tkers tkers merged commit c0b0306 into master Mar 24, 2019
@tkers tkers deleted the printer-id-test branch March 24, 2019 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants