Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parent auto check not working properly with checked and disabled children #233

Open
mariusz-jachimowicz-83 opened this issue Apr 7, 2021 · 0 comments

Comments

@mariusz-jachimowicz-83
Copy link

There is mechanism to auto check parent if all children are checked https://github.com/amsik/liquor-tree/blob/master/src/lib/Node.js#L124
It doesn't work properly if any child item is checked: true and disabled: true because it makes parent item unchecked instead of checked.

refreshIndeterminateState counts checked and disabled children items and based on that it apply checked state https://github.com/amsik/liquor-tree/blob/master/src/lib/Node.js#L151 so it works if disabled items are unchecked. But disabled items might be initially checked and in that case it doesn't work properly.

luquor-tree-checking-issue

Would be good to decide should disabled children be ignored or included while making parent checked because we also have checkDisabledChildren option so it might matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant