Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Time #20

Closed
pvledoux opened this issue Nov 22, 2012 · 20 comments
Closed

Add Time #20

pvledoux opened this issue Nov 22, 2012 · 20 comments

Comments

@pvledoux
Copy link

Hi,

I would like to add the time to your wonderful date picker.

I did something like:

var now = new Date();
var $custom_date = $( '#input_03' ).pickadate({
    format: 'You selected: dddd, dd/mm/yyyy '+ now.toTimeString(),
    format_submit: 'yyyy-mm-dd HH:MM:ss'
}

but the submitted time is HH:MM:ss. How can I handle that?

@eruiz
Copy link

eruiz commented Nov 23, 2012

+1

@cemo
Copy link

cemo commented Nov 26, 2012

I bet that this issue will be the most wanted one. :) 👍

@amsul
Copy link
Owner

amsul commented Nov 26, 2012

I'm not so sure I understand what you're doing here. Since there's no way for the user to select a time, this will only append the time at which they selected a date.
Is that the goal?

@cemo
Copy link

cemo commented Nov 26, 2012

I am not sure about original intention but I desperately need time support for pickadate.

@pvledoux
Copy link
Author

The user don't have to 'pick' a time. In my example I just add the current time, and user can edit it by hand if necessary.

@mgibbs189
Copy link

If time support were added, it would need a UI. Even something as simple as a dropdown or two.

@pvledoux
Copy link
Author

Or just the ability to edit the field (as it was a text field, like jquery datepicker)?

@amsul
Copy link
Owner

amsul commented Nov 30, 2012

Not being able to edit the field is important because we want nicely formatted values for the server.

I think time selection warrants a plugin of it's own because of the various ways in which you can ask for and display time..

@amsul amsul mentioned this issue Nov 30, 2012
@garbas
Copy link
Contributor

garbas commented Jan 7, 2013

+1 ... time support would be awesome

@eruiz
Copy link

eruiz commented Jan 8, 2013

my two cents for time support

@dv336699
Copy link

yip +1
I've been using this one, but I'm getting sick to always include jquery ui just for this picker.
http://trentrichardson.com/examples/timepicker/

Thanks

@amsul
Copy link
Owner

amsul commented Jan 22, 2013

I've been thinking of the various ways to implement time into the plugin. It doesn't seem like there's a nice and clean way of doing this without using too much screen real estate - which is a problem on mobile.

I have a couple ideas I'm playing around with (such as appending another input element for time) which I'll share here soon.

If you guys have seen any other good implementations of a time picker, please do share!

@garbas
Copy link
Contributor

garbas commented Jan 23, 2013

Quoting Cemalettin Koc (2013-01-23 08:31:26)

http://tarruda.github.com/bootstrap-datetimepicker/
http://www.ama3.com/anytime/
http://trentrichardson.com/examples/timepicker/
http://labs.perifer.se/timedatepicker/
http://jonthornton.github.com/jquery-timepicker/
http://2007.electronicholas.com/calendar
http://jdewit.github.com/bootstrap-timepicker/

i really like bootstrap-datetimepicker aproach since it also works nice for
mobile devices.

just dont like that its based on bootstrap

Rok Garbas - http://www.garbas.si

@amsul
Copy link
Owner

amsul commented Jan 23, 2013

@cemo, nice - that's an awesome variety of options.

I like Jon Thornton's (Google calendar) implementation the best from a UX perspective. One click to pick a time and you're done.

@stas
Copy link

stas commented Feb 2, 2013

Some time ago I sent a PR for the same functionality at Pikaday/Pikaday/pull/18
Looks like the project got abandoned and I'm looking for a more actively deployed alternative.

If you think the work I've done there is something you will consider merging, I can try another PR.

@esbanarango
Copy link

+1, I really support this feature!

@amsul
Copy link
Owner

amsul commented Feb 14, 2013

@stas that looks like a pretty good solution.

I've been working on something a little different than that.. The time-picker branch has a working demo of how it works at the moment. Still needs quite a bit of clean up and testing.

@pvledoux
Copy link
Author

Look nice! Is it possible to set a time by default? I mean, selecting the current time when you click on the box?

@amsul
Copy link
Owner

amsul commented Apr 27, 2013

...and 2 months later, let’s continue the discussion here: v3.0.0: rewrite + time picker 😄

@amsul amsul closed this as completed Apr 27, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants