New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Picker css class conflicts with Google Drive Picker #619
Comments
+1 maybe we change .picker to be .pad-picker or .pickadatepicker? |
+1 |
+2 |
Do you think we could get an update on this ? |
this worked for me .picker-dialog-content { |
@felipemarin thanks. it worked me too. |
That works but I think it should be fixed in the next release perhaps? @amsul, would you like me to prepare a PR? I guess it's quite a major change, so perhaps we need to release a new major release? |
In most cases people can adjust the styles and use scoped styles. Not sure if we should change this as I did not see more issues and comments related to this. |
I would agree with @DanielRuf. This can easily be solved with scoped styles - plus it'd be a major breaking change for anyone using the project with custom styles. Maybe it would be better to add an option that appends a custom prefix to the class names (although the CSS names would somehow need to get prefixed accordingly as well) |
@DanielRuf, are you referring to adjusting Pickadate's styles? Could you elaborate on this a bit? The issue did cause me a fair bit of confusion with regards to the google file picker as suddenly it just showed up as a little dot on the screen and it wasn't obvious that Pickadate's style overlap was the cause. Only a random (lucky) google search came up with someone that had a similar problem and had asked about an unrelated error message emitted by google picker. |
The css class 'picker' used by pickadate.js conflicts with the picker class used by the Google Drive Picker (https://developers.google.com/picker).
This class should be customizable when configuring the plugin, randomly generated, or more unique (e.g. a prefix) so that it doesn't conflict with other plugins.
The text was updated successfully, but these errors were encountered: