Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No HTTP user-agent makes it hard for podcasters #21

Closed
jamescridland opened this issue Feb 11, 2021 · 2 comments
Closed

No HTTP user-agent makes it hard for podcasters #21

jamescridland opened this issue Feb 11, 2021 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@jamescridland
Copy link

jamescridland commented Feb 11, 2021

Describe the bug

This app does not seem to set an HTTP useragent for its audio player. This is bad, and means podcasters do not know what product is consuming their free content.

To Reproduce
Steps to reproduce the behavior:

Listen to a podcast. The podcast publisher gets this as an HTTP useragent:

just_audio/0.2.0 (Linux;Android 6.0) ExoPlayerLib/2.12.2

This is the player within this app. It should be something like

Anytime/0.2.0 (Linux;Android 6.0) https://github.com/amugofjava/anytime_podcast_player

Expected behavior
Send a correct HTTP useragent

Screenshots
None

Smartphone (please complete the following information):
I've no idea what smartphone this user is using, other than it appears to be running Android 6, so is very old.

Additional context

A full set of useragents are here: https://github.com/opawg/user-agents

I've spotted your app here: https://podnews.net/about/podcast-stats

@amugofjava
Copy link
Owner

Thanks @jamescridland for raising this bug. Have fixed it locally and will push an update as soon as possible. You should see a more appropriate user agent appear:

Anytime/0.2.1 (phone;Android 10) https://github.com/amugofjava/anytime_podcast_player

@amugofjava amugofjava self-assigned this Feb 11, 2021
@amugofjava amugofjava added the bug Something isn't working label Feb 11, 2021
@amugofjava
Copy link
Owner

Issue resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

2 participants