New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Show Funding Menu settings to show/hide FundingMenu on PodcastDetails #32
Conversation
…ails This setting will be true by default and won't be configurable through Settings.
Hi @erdemyerebasmaz, Would a podcast not potentially support both Lightning and Funding links, or are you presenting the funding links within Breez itself? |
@amugofjava only Lightning is supported in Breez |
Hi, I've made a slight adjustment to podcast details. Returning a settings_jank.mp4settings_fixed.mp4 |
Good catch! @amugofjava SVID_20210317_123623_1.mp4What we should do is to move StreamBuilder inside Column children where FundingMenu is:
This way the wait won't affect the whole widget. |
@amugofjava Please see my comment above. |
Hi @erdemyerebasmaz, Yes, I'll give that a try and see if it improves things. |
Hi @erdemyerebasmaz, I tried moving the stream closer to the widget using it. It's good practice but made no difference. So, I have changed the settings BLoC to allow direct access to the current settings. This does break the 'contract' that BLoCs should only be accessed via sinks and streams, but in this case I think it's more important to have a jank free ui! :) I hadn't noticed until I saw your video that the play button was janky too so I have also fixed that. |
Since we have our own payment system integrated into the plugin via hooks, this raised the need to hide
FundingMenu
onPodcastDetails
page. We believe the least intrusive way to go with this change was to add ashowFunding
flag toAppSettings
.This PR introduces
showFunding
settings flag that allows developers to hideFundingMenu
onPodcastDetails
page.This setting is
true
by default and won't be configurable throughSettings
page.