New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh the podcast on Podcast Details page creation #51
Refresh the podcast on Podcast Details page creation #51
Conversation
Hi @ademar111190, Thanks for the pull request. Background/auto refresh is something I am looking into. There are a couple of issues with the podcast load routine which has stopped me calling
Both issues shouldn't be too hard to resolve, but as it stands I feel calling refresh on load may give a poorer user experience than having to refresh manually in the short term. refresh.mp4 |
Thank you for the feedback @amugofjava I'll think in something that updates without those undesirables side effects. |
@amugofjava this is something Breez users keep straggling with. I get feedback on this issue on a daily basis. |
@ademar111190 @amugofjava For the first issue we can pass a flag (background: true) to the Feed entity when calling handleRefresh. The podcast_bloc will fail silently in case of errors (network error, etc...). I think it will solve the first issue. LMK your thoughts. |
Hi @roeierez, Yes, that is exactly my thinking for both points. This seems to be the simplest solution and shouldn't be difficult to implement. In addition, I am also thinking of adding settings to set the background refresh to be Off, On (always), On (Wifi-Only). I will also add a cache time - i.e. don't bother refreshing again if you did so only 5 minutes ago; podcasts won't necessarily update that frequently. If I make all these options configurable settings then you can use or ignore them how to feel best suits Breez. |
Hi, thanks for the feedback and the insights. I think I did solve both issues with my last changes. May you guys can check it one more time? I was thinking about some settings too, it doesn't seem to be difficult, but I don't have much clue about how to design it properly and keep a good experience for the user. |
Look good to me. |
Thanks @ademar111190, this looks good to me too. I will add the settings around your changes and push the update to |
I have found one small issue @ademar111190 in that because the load process is now being called twice in the |
This is the current state of the auto-refresh. It needs finalising and thorough testing, but I think this solution will work. The stuttery-ness of the video is not a reflection on Anytime, just the poor recording ability of the emulator running a debug build. auto_refresh.mp4 |
@amugofjava great UI. One suggestion: add a spinner on top of the podcast image while new episodes are loading so people understand something is going on. |
Add a minor convenience to the user, whenever the user opens the podcast detail it silently updates the list of episodes.
Based on this suggestion: breez/breezmobile#456
How it looks like
auto-refresh.mp4