Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose which packet definitions to use (Model S, Model 3, Model S DBC, etc.) #18

Closed
Bokonon79 opened this issue Jan 5, 2019 · 3 comments

Comments

@Bokonon79
Copy link
Collaborator

At the moment, CANBUS-Analyzer can only load the hard-coded Model S packet definitions for analysis.

Adding a "mode" or "definitions" selector (e.g. dropdown list) to the UI would allow the user to switch between different analysis modes (assuming the modes are exclusive of one another). Options might include:

Model S Defaults (hard-coded definitions)
Model 3 Defaults (hard-coded definitions)
Model S RWD DBC file
Model S AWD DBC file
Model 3 DBC file

@amund7
Copy link
Owner

amund7 commented Jan 5, 2019

I think we are close, if not already at where we could just load any DBC file for any car. So maybe the dropdown should be

  • Model S (ScanMyTesla)
  • Model 3 (ScanMyTesla)
  • Load DBC file

the latter would pop up an open dialog. After loading several DBC files, they should stay in that box for quick select/load later on.

The reason I tag it with ScanMyTesla is that those options would show also the compound signals SMT provides, that are impossible in DBC, such as battery power (kW) calculated from simply watt*volts.

Just an idea, but we are moving fast towards compatibility with any DBC file, and we should start preparing the UI for it.

@brian-man
Copy link
Collaborator

Hope:
At some point hopefully there will be one or more packets we can use to identify the vehicle type enough to appropriately choose the right DBC file automatically.

@amund7
Copy link
Owner

amund7 commented Jan 11, 2019

I don't think we should stress that, if we support DBC files, we support ANY dbc file, right? Meaning, volvos, audis, school buses whatever.

But perhaps it can be done for model3 / S ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants