Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve or rethink "Interpret as", "copy ID" functionality #25

Open
amund7 opened this issue Jan 9, 2019 · 0 comments
Open

Improve or rethink "Interpret as", "copy ID" functionality #25

amund7 opened this issue Jan 9, 2019 · 0 comments

Comments

@amund7
Copy link
Owner

amund7 commented Jan 9, 2019

Snipped from the model3 forum thread, where I tried to explain how to use these buttons. It's quite obvious that this is not exactly user friendly in it's current state:

Now the 'copy ID' and 'interpret as' buttons need a packet to pre-exist so it can be selected, but with a model S log (or load a model S log before the 3 log) you could do:

  • Select a known packet / with description in the left pane
  • Click 'copy id' (button will now change into that ID)
  • Click a blank/unknown packet ID
    Repeat fiddly bits:
    Fiddly bit 1: Unselect and re-select the CAN ID in the left pane again (to force refresh the graph and signals)
    Fiddly bit 2: Might have to reload the file, or click the << or >> to load the next/previous file in that folder, to stream some new data.

Ideas:

  • create a pulldown that lets you select any known packet, regardless if it has been recieved yet, also across model S, X, perhaps DBC files ?
  • create a more intuitive way to interpret as bytes, 12-bit, 10-bit etc. Comma.ai has a super intuitive click&drag in the bits display to place a signal from/to any bits.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant