Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update README.md #301

Merged
merged 1 commit into from Jul 7, 2020
Merged

fix: Update README.md #301

merged 1 commit into from Jul 7, 2020

Conversation

duyet
Copy link
Contributor

@duyet duyet commented Jul 7, 2020

Summary of Changes

Updated the contents of README.md and fix a typo mistake.

Tests

None needed, only updates documentation

Documentation

None

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
  • PR passes make test

@duyet duyet changed the title Fix: Update README.md fix: Update README.md Jul 7, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2020

Codecov Report

Merging #301 into master will increase coverage by 0.27%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #301      +/-   ##
==========================================
+ Coverage   73.17%   73.45%   +0.27%     
==========================================
  Files         103      103              
  Lines        4328     4328              
  Branches      384      403      +19     
==========================================
+ Hits         3167     3179      +12     
+ Misses       1053     1049       -4     
+ Partials      108      100       -8     
Impacted Files Coverage Δ
databuilder/task/neo4j_staleness_removal_task.py 85.00% <0.00%> (+0.83%) ⬆️
databuilder/publisher/neo4j_csv_publisher.py 84.43% <0.00%> (+0.94%) ⬆️
databuilder/extractor/mssql_metadata_extractor.py 95.52% <0.00%> (+1.49%) ⬆️
...abuilder/extractor/snowflake_metadata_extractor.py 95.31% <0.00%> (+1.56%) ⬆️
...tabuilder/extractor/postgres_metadata_extractor.py 95.16% <0.00%> (+1.61%) ⬆️
...ilder/transformer/regex_str_replace_transformer.py 96.42% <0.00%> (+3.57%) ⬆️
databuilder/loader/file_system_neo4j_csv_loader.py 89.28% <0.00%> (+5.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21a763a...4247d9d. Read the comment docs.

@jornh
Copy link
Contributor

jornh commented Jul 7, 2020

Nice catch! 👍

Copy link
Member

@feng-tao feng-tao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix

@feng-tao feng-tao merged commit ad5765a into amundsen-io:master Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants