Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Mode Batch dashboard chart extractor using discovery API #362

Merged
merged 1 commit into from Sep 9, 2020

Conversation

feng-tao
Copy link
Member

@feng-tao feng-tao commented Sep 9, 2020

Signed-off-by: feng-tao fengtao04@gmail.com

Summary of Changes

Leverage the latest mode discovery API(https://mode.com/help/articles/discovery-api/) which is much more performant than the previous version. Feel free to check out mode's blog post(https://mode.com/blog/new-features-to-help-you-manage-users-and-discover-data-at-scale/)

Previous mode chart legacy API doesn't work as it doesn't return the full data.

Tests

yes with Lyft staging as well

Documentation

yes

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
  • PR passes make test

@feng-tao feng-tao changed the title feat: Mode Batch dashboard charrt API feat: Mode Batch dashboard chart API Sep 9, 2020
@feng-tao feng-tao mentioned this pull request Sep 9, 2020
5 tasks
@feng-tao feng-tao changed the title feat: Mode Batch dashboard chart API feat: Mode Batch dashboard chart extractor using discovery API Sep 9, 2020
Signed-off-by: feng-tao <fengtao04@gmail.com>
Copy link
Contributor

@dikshathakur3119 dikshathakur3119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jinhyukchang jinhyukchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@feng-tao feng-tao merged commit 87213c5 into master Sep 9, 2020
@feng-tao feng-tao deleted the tfeng_mode_batch_chart branch September 9, 2020 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants