Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add an extractor for pulling user information from BambooHR #369

Merged

Conversation

nathanlawrence-asana
Copy link
Contributor

@nathanlawrence-asana nathanlawrence-asana commented Sep 18, 2020

Summary of Changes

Add a new extractor for pulling user information (team, role, email address, name from BambooHR)

Tests

Yep! There's a simple new test that mocks the HTTP request to BambooHR's API and checks that the XML parsing logic is working as expected.

Documentation

No new documentation added. Happy to add some if folks point me in the right direction.

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
  • PR passes make test

# SPDX-License-Identifier: Apache-2.0


from pyhocon import ConfigTree
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution, could we move the module to databuilder/extractor/user/boomboohr ? this helps to add other user extractor later. Also eventually I plan to refactor and do the same dataset/table extractor. thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Will do.

Looks like I also have a unit test failure that I'll need to debug.

@nathanlawrence-asana nathanlawrence-asana force-pushed the nathanlawrence-bamboohr branch 2 times, most recently from c053967 to 6496eb6 Compare September 18, 2020 23:12
@jornh
Copy link
Contributor

jornh commented Sep 19, 2020

Great contribution @nathanlawrence-asana 👍

No new documentation added. Happy to add some if folks point me in the right direction.
You could add to the Extractors section of the README.md right after https://github.com/amundsen-io/amundsendatabuilder#tableauexternaltableextractor

@feng-tao
Copy link
Member

CI fails

@nathanlawrence-asana nathanlawrence-asana force-pushed the nathanlawrence-bamboohr branch 5 times, most recently from b69fbdf to 80d33a6 Compare September 22, 2020 18:54
Signed-off-by: Nathan Lawrence <nathanlawrence@asana.com>
@nathanlawrence-asana
Copy link
Contributor Author

🏁 Alright, tests are (finally) passing and I've added a section to the README.md file. Please let me know if there's anything else you'd like me to clean up / update (and thank you both for your feedback and support).

@feng-tao
Copy link
Member

thanks @nathanlawrence-asana , will take a look today

Copy link
Member

@feng-tao feng-tao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the change lgtm, thanks for the contribution!

@@ -0,0 +1,39 @@
<?xml version="1.0"?>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting, haven't seen xml for a while :)

@feng-tao feng-tao merged commit 6802ab1 into amundsen-io:master Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants