New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add an extractor for pulling user information from BambooHR #369
feat: Add an extractor for pulling user information from BambooHR #369
Conversation
e0b3133
to
baf2518
Compare
# SPDX-License-Identifier: Apache-2.0 | ||
|
||
|
||
from pyhocon import ConfigTree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the contribution, could we move the module to databuilder/extractor/user/boomboohr
? this helps to add other user extractor later. Also eventually I plan to refactor and do the same dataset/table extractor. thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Will do.
Looks like I also have a unit test failure that I'll need to debug.
c053967
to
6496eb6
Compare
Great contribution @nathanlawrence-asana 👍
|
CI fails |
b69fbdf
to
80d33a6
Compare
Signed-off-by: Nathan Lawrence <nathanlawrence@asana.com>
80d33a6
to
793e76b
Compare
🏁 Alright, tests are (finally) passing and I've added a section to the README.md file. Please let me know if there's anything else you'd like me to clean up / update (and thank you both for your feedback and support). |
thanks @nathanlawrence-asana , will take a look today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the change lgtm, thanks for the contribution!
@@ -0,0 +1,39 @@ | |||
<?xml version="1.0"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting, haven't seen xml for a while :)
Summary of Changes
Add a new extractor for pulling user information (team, role, email address, name from BambooHR)
Tests
Yep! There's a simple new test that mocks the HTTP request to BambooHR's API and checks that the XML parsing logic is working as expected.
Documentation
No new documentation added. Happy to add some if folks point me in the right direction.
CheckList
Make sure you have checked all steps below to ensure a timely review.
make test