Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sample Feast job with ES publisher #425

Merged
merged 1 commit into from Dec 10, 2020

Conversation

szczeles
Copy link
Contributor

Summary of Changes

Feast sample job modified to not only do a Feast -> Neo4j extraction, but also Neo4j -> ES publishing. It's better suited for the demo purposes now.

Tests

No tests, only sample job modification. Sample job tested manually:

root@feast-loader:/# python sample_feast_loader.py feast-feast-core:6565 bolt://neo4j http://amundsen-elasticsearch-client:9200

WARNING:elasticsearch:GET http://amundsen-elasticsearch-client:9200/table_search_index/_alias [status:404 request:0.031s]
WARNING:databuilder.publisher.elasticsearch_publisher:Received index not found error from Elasticsearch. The index doesn't exist for a newly created ES. It's OK on first run.
root@feast-loader:/# 

Documentation

Header in the sample script with usage.

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
  • PR passes make test

Signed-off-by: Mariusz Strzelecki <mariusz.strzelecki@getindata.com>
@szczeles
Copy link
Contributor Author

@feng-tao Could you please have a look in spare time?

@feng-tao feng-tao merged commit 453a18b into amundsen-io:master Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants