fix: Avoid error by checking for existence before close. #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davcamer
requested review from
allisonsuarez,
dikshathakur3119,
feng-tao and
jinhyukchang
as code owners
davcamer
force-pushed
the
check-existence-before-close
branch
from
40a0e03
to
f8699d6
Compare
…ors. A common pattern has emerged where database-specific extractors delegate the execution of queries to a SQLAlchemyExtractor instance. The DB specific extractor has the code tailored to a DB's metadata table structure. The SQLAlchemyExtractor has the basic connection lifecycle code. The pattern involved a few lines of tricky-looking code to handle configs that looks like it has been copy-pasted from one config to the next. This pulls that out in to a factory function in the sql_alchemy_extractor module. Signed-off-by: Dave Cameron <dcameron@digitalocean.com>
Without checking the existence of the _alchemy_extractor attribute, and that the value is not None, an AttributeError can be raised when close() if called if the init method didn't complete. Tasks still call close to clean up, so this code should check if there is anything to clean up first. Signed-off-by: Dave Cameron <dcameron@digitalocean.com>
davcamer
force-pushed
the
check-existence-before-close
branch
from
f8699d6
to
3a1539d
Compare
feng-tao
approved these changes
Mar 5, 2021
|
thanks for making it DRY! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Without checking the existence of the
_alchemy_extractorattribute, and thatthe value is not None, an AttributeError can be raised when close() is called
if the init method didn't complete. Tasks still call close to clean up, so
this code should check if there is anything to clean up first.
Tests
No tests were added. I am not familiar enough with mocking to set up effective tests.
Documentation
No documentation was added.
CheckList
Make sure you have checked all steps below to ensure a timely review.
make test