Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass **kwargs for do_gunzip and run_gunzip (downloader.py) #113

Open
GoogleCodeExporter opened this issue Apr 8, 2016 · 1 comment
Open

Comments

@GoogleCodeExporter
Copy link

there are some inconsistency. do_gunzip and run_gunzip are not getting 
**kwargs, but uncompress_file function definitely pass **kwargs. Thus, 
proposed solution for this is to remove **kwargs or pass **kwargs on 
do_gunzip and run_gunzip. It will be a lot easier in terms of automatic 
checking of compressed files...


def do_gunzip(filepath,newpath=None):
def run_gunzip(filepath,newpath=None):

    elif filepath.endswith('.gz'):
        logger.info('gunzipping %s...' % filepath)
        try:  # could use gzip module, but it's two times slower!!
            return run_gunzip(filepath, **kwargs) # run as sub process
        except OSError: # on Windows, have to run as python module
            return do_gunzip(filepath, **kwargs)

Now, for seqdb downloading, always pass singleFile=True. 

src = SourceURL(newurl, filename = genoname + mytype, singleFile = True)

Original issue reported on code.google.com by deepr...@gmail.com on 4 Sep 2009 at 1:38

@GoogleCodeExporter
Copy link
Author

Original comment by mare...@gmail.com on 4 Sep 2009 at 8:42

  • Changed state: Accepted
  • Added labels: Milestone-Release0.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant