Adds flag to mark some tests as out-of-scope for ion-schema-schemas #35
Conversation
| } | ||
|
|
||
| $test::{ | ||
| description: "byte_length range must not be non-empty", |
There was a problem hiding this comment.
The phrase "must not be non-empty" occurs in many of these, and it really confused me until I realized that "empty" referred to the values that could satisfy the range, rather than the range declaration itself. But even if "empty" weren't confusing, don't we mean "must not be empty"?
There was a problem hiding this comment.
You're right—there's an accidental double negative there.
"range must be satisfiable" maybe?
I understand where you're coming from, but I guess I don't mind the repetitiveness compared to the value from being able to come back to it later and read why it is that ISL for ISL cannot validate (or invalidate?) it. I don't hold this opinion very strongly, though, so I will switch to something without the string value. |
Issue #, if available:
#32
Description of changes:
Updates the test spec with a way to mark tests that should be skipped when testing with ISL for ISL, and updates all Ion Schema Tests that need to be skipped.
Rather than having a blocked/skip list in every implementation that runs the ISL for ISL tests, we should just mark the test cases themselves and include a reason why the test case is to be skipped. This approach is better than the existing approach because it is more fine-grained than having a file-based blocked/skip list, and it documents the reason the particular test cases are skipped.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.