Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: resolve using an underscore prefixed environment #93

Merged
merged 1 commit into from
Jun 23, 2017

Conversation

dsludwig
Copy link
Contributor

This allows conda to be resolved as a dependency, in case
there is an environment spec that depends on it. That environment
will still fail to install unless it also starts with an
underscore.

This allows conda to be resolved as a dependency, in case
there is an environment spec that depends on it. That environment
will still fail to install unless it *also* starts with an
underscore.
@dsludwig dsludwig requested review from havocp and necaris June 23, 2017 16:47
@havocp
Copy link
Contributor

havocp commented Jun 23, 2017

lgtm once ci passes go ahead and merge. I can build a 0.7.1 this afternoon

@havocp havocp merged commit 70573a2 into master Jun 23, 2017
@havocp havocp deleted the allow-locking-underscore-envs branch June 23, 2017 17:40
@goanpeca goanpeca added this to the v0.8.1 milestone Oct 3, 2017
@goanpeca goanpeca changed the title conda: resolve using an underscore prefixed environment PR: resolve using an underscore prefixed environment Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants