Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise warning if user has requests > 2.7 and PyOpenSSL, etc installed #256

Closed
dsludwig opened this issue Dec 2, 2015 · 1 comment
Closed

Raise warning if user has requests > 2.7 and PyOpenSSL, etc installed #256

dsludwig opened this issue Dec 2, 2015 · 1 comment
Assignees
@dsludwig
Labels
type:bug

Comments

@dsludwig
Copy link
Contributor

dsludwig commented Dec 2, 2015

In order to mitigate #222 and #244 and allow upgrading requests, we should issue a warning if a user has an environment where this bug will exhibit. That means:

  • requests.packages.urllib3.contrib.pyopenssl is importable
  • requests.__version__ is > 2.7

Still proceed with the upload, just detect and warn.

@srossross what should the warning direct users to do? Uninstall the PyOpenSSL libraries? Or downgrade requests? If they are running it as part of a root anaconda install, is either of those options feasible?
@dsludwig dsludwig self-assigned this Dec 2, 2015
@dsludwig dsludwig mentioned this issue Dec 2, 2015
Merged
@dsludwig dsludwig closed this as completed Dec 4, 2015
@dsludwig
Copy link
Contributor Author

dsludwig commented Dec 4, 2015

Added in the latest release.

@dsludwig dsludwig mentioned this issue Mar 3, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsludwig dsludwig

Labels
type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dsludwig