Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go-flags prevents blockfile use with cmd/torrent #37

Closed
errnoh opened this issue Oct 29, 2015 · 3 comments
Closed

go-flags prevents blockfile use with cmd/torrent #37

errnoh opened this issue Oct 29, 2015 · 3 comments

Comments

@errnoh
Copy link

errnoh commented Oct 29, 2015

https://github.com/anacrolix/torrent/blob/master/cmd/torrent/main.go#L80 seems to fill rootGroup.Client.IPBlocklist with &{[]}.

This causes if cfg.IPBlocklist != nil to always resolve true, which then prevents the call to cl.setEnvBlocklist()
@anacrolix
Copy link
Owner

Great catch, thanks.

@errnoh
Copy link
Author

errnoh commented Oct 30, 2015

Since this is mostly a problem in go-flags end I submitted ticket over there as well: jessevdk/go-flags#151

@anacrolix
Copy link
Owner

Thanks, I've come up with my own implementation, let me know if you have any issues or thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@errnoh @anacrolix