Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panic in utp ackSyn() #425

Closed
luodw opened this issue Sep 17, 2020 · 4 comments
Closed

panic in utp ackSyn() #425

luodw opened this issue Sep 17, 2020 · 4 comments
Assignees

Comments

@luodw
Copy link

luodw commented Sep 17, 2020

hello, our p2p is based on anacrolix/torrent. In recent days, our p2p restart accidentally. see the log,we found panic in https://github.com/anacrolix/utp/blob/master/socket.go#L493
image.

I found incoming and outgoing conn will both add to socket.conns(map[connKey]*Conn, when accept a incoming conn, it will add to socket.conns,if socket.conns already has the same conn, it will panic. is there must be panic?or is there something wrong?

ps: we use both tcp and utp

image

@luodw luodw closed this as completed Sep 17, 2020
@luodw luodw reopened this Sep 17, 2020
@anacrolix
Copy link
Owner

It's recommend to use https://github.com/anacrolix/go-libutp instead. Could you change to that implementation?

@luodw
Copy link
Author

luodw commented Sep 19, 2020

It's recommend to use https://github.com/anacrolix/go-libutp instead. Could you change to that implementation?

Thanks for your reply, I will have a try

@anacrolix
Copy link
Owner

@luodw do you have an update? Did you switch to go-libutp? You can open a PR against anacrolix/utp if you have found a workaround.

@luodw
Copy link
Author

luodw commented Feb 18, 2021

@luodw do you have an update? Did you switch to go-libutp? You can open a PR against anacrolix/utp if you have found a workaround.

@anacrolix I use go-libutp and fix the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants