Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Items counter test #76

Merged
merged 2 commits into from May 18, 2022
Merged

Items counter test #76

merged 2 commits into from May 18, 2022

Conversation

anagudelogu
Copy link
Owner

@anagudelogu anagudelogu commented May 18, 2022

In this Milestone I:

  • Added a test case to the itemsCount function when there are no items in the DOM list.
  • Added a test case to the itemsCount function when an item gets added to the DOM list.
  • Added a test case to the itemsCount function when n items get added to the DOM list.

closes #45

When there are no items in the list.
When 1 item gets added to the list.
When n items get added to the list.
Copy link
Collaborator

@Danie12345 Danie12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STATUS: APPROVED ✅🤑🤑

Hi @anagudelogu 👋

Good job making the unit tests!

There's nothing else to say other than it's time to MERGE it! :D

To Highlight 🎉

  • No linter errors. ✔️
  • GitHub flow is followed. ✔️
  • Professional README file. ✔️
  • Good commit messages. ✔️
  • PR has a good description and title ✔️

Required Changes ♻️

  • None! :D

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@anagudelogu anagudelogu merged commit 21e85aa into dev May 18, 2022
@anagudelogu anagudelogu deleted the items-counter-test branch May 18, 2022 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[3pt] - Add tests for items counter - Student A
2 participants