Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.combine not working for jQuery.validate.min.js #5

Closed
jakejscott opened this issue Jun 8, 2011 · 3 comments
Closed

.combine not working for jQuery.validate.min.js #5

jakejscott opened this issue Jun 8, 2011 · 3 comments
Milestone

Comments

@jakejscott
Copy link

Hi Paul I have just downloaded and ran the SassAndCoffee.WebTest website.

I changed it to use the minified javascript and get errors on page load in firebug

<script src="@Url.Content("~/Scripts/prod_all.js")" type="text/javascript"></script>

I think there is a problem with the way jQuery.validate.min.js and jquery.validate.unobtrusive.min.js have been minified?

Cheers
Jake

@anaisbetts
Copy link
Owner

Hmmm, I'll take a look - might be a bug in Uglify. Thanks!

@RoyTinker
Copy link

I know uglifyjs has some potentially unsafe transformations that it takes - the author documents this. Perhaps a flag/setting could be passed that would avoid all potentially unsafe transformations? (By the way, I'm getting errors when minifying json.js from json.org).

@kogir
Copy link
Contributor

kogir commented Dec 5, 2011

This should be fixed now both by a) using the file on disk if it already exists (don't minify a minified file), and b) the fix to #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants