Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

route53: boto3 should not be optional #93

Closed
willfarrell opened this issue Jan 17, 2017 · 3 comments
Closed

route53: boto3 should not be optional #93

willfarrell opened this issue Jan 17, 2017 · 3 comments

Comments

@willfarrell
Copy link

I've found that pip install dns-lexicon[route53] does not install the required dep boto3. See error below. Example use/workaround can be found at https://github.com/willfarrell/docker-letsencrypt/blob/master/Dockerfile

Namespace(action='list', auth_access_key=None, auth_access_secret=None, auth_token=None, auth_username=None, content=None, domain='ductoid.com', identifier=None, name=None, priority=None, provider_name='route53', ttl=None, type='A')
Traceback (most recent call last):
  File "/usr/bin/lexicon", line 11, in <module>
    load_entry_point('dns-lexicon==1.1.20', 'console_scripts', 'lexicon')()
  File "/usr/lib/python2.7/site-packages/lexicon/__main__.py", line 51, in main
    client = Client(parsed_args.__dict__)
  File "/usr/lib/python2.7/site-packages/lexicon/client.py", line 22, in __init__
    self.provider = provider_class(self.options)
  File "/usr/lib/python2.7/site-packages/lexicon/providers/route53.py", line 80, in __init__
    self.r53_client = boto3.client(
NameError: global name 'boto3' is not defined

I would submit a PR, but python is a little out of my wheelhouse.

@AnalogJ
Copy link
Owner

AnalogJ commented Jan 23, 2017

Hey @willfarrell
I've pulled out route53 in the recent version. I want to make sure that lexicon works in python 2.7, 3.4 and 3.5 but there were some issues with the Route53 and Gandi providers.

@willfarrell
Copy link
Author

willfarrell commented Jan 23, 2017

Thanks for the update.

Just realize pip wasn't pulling v1.2.1, so pushed an update to willfarrell/docker-letsencrypt. I'll keep an eye out for new version.

@AnalogJ
Copy link
Owner

AnalogJ commented Jan 25, 2017

v1.2.2 should be available on pip now as well. Adds support for Yandex.

@AnalogJ AnalogJ closed this as completed Jan 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants