Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @ngtools/webpack to peer deps of @analog/vite-plugin-angular #1053

Merged

Conversation

jculvey
Copy link
Contributor

@jculvey jculvey commented Apr 24, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-plugin-angular
  • vite-plugin-nitro
  • astro-angular
  • create-analog
  • router
  • platform
  • content
  • nx-plugin
  • trpc

What is the current behavior?

Analog currently fails to build with yarn and bun.

This can be reproduced via the following:

  • bun create analog my-project
  • cd my-project
  • bun install
  • bun run build

Observe the error:

An unhandled exception occurred: Cannot find package '@ngtools/webpack' imported from my-project/node_modules/@analogjs/vite-plugin-angular/src/lib/host.js

This problem occurs since bun and yarn don't hoist dependencies by default, and @ngtools/webpack is referenced in @analog/vite-plugin-angular

See also: #1048.

Closes #1045

What is the new behavior?

@ngtools/webpack will be resolved as a peer dependency when using bun or yarn and build successfully 🤞.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Apr 24, 2024

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit 12ca684
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/662af556de480e000807b27b
😎 Deploy Preview https://deploy-preview-1053--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 24, 2024

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit 12ca684
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/662af556f6e5b600089e722c
😎 Deploy Preview https://deploy-preview-1053--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 24, 2024

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit 12ca684
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/662af5568a64a300087e9e1b
😎 Deploy Preview https://deploy-preview-1053--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 24, 2024

Deploy Preview for analog-ng-app ready!

Name Link
🔨 Latest commit 12ca684
🔍 Latest deploy log https://app.netlify.com/sites/analog-ng-app/deploys/662af556fa07880008b09677
😎 Deploy Preview https://deploy-preview-1053--analog-ng-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brandonroberts brandonroberts merged commit c6490e2 into analogjs:beta Apr 26, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: yarn fails to install peer dependencies, causing app to fail when serving
2 participants