New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pylint #522
Fix pylint #522
Conversation
Codecov Report
@@ Coverage Diff @@
## master #522 +/- ##
==========================================
- Coverage 41.46% 41.38% -0.09%
==========================================
Files 147 148 +1
Lines 14587 14843 +256
==========================================
+ Hits 6049 6143 +94
- Misses 8538 8700 +162
Continue to review full report at Codecov.
|
@nikita-klsh It seems |
@roman-kh There are no releases with updates yet. Or we want to build it from github? |
Running |
batchflow/dataset.py
Outdated
@@ -75,7 +75,6 @@ def __init__(self, index, batch_class=Batch, *args, preloaded=None, cast_to_arra | |||
self._attrs = None | |||
kwargs['_copy'] = kwargs.get('_copy', copy) | |||
self.n_splits = None | |||
self.train, self.test = None, None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you think this is a better approach?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks weird to reinitialize attributes, that have already been initialized in the parent class Baseset
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I return it as it was initially and plug pylint: disable=attribute-defined-outside-init
stub.
In the code we assign values to self.train / self.test / self.validation
attributes that WERE defined in the init
.
It looks like pylint false positive
This PR fixes pylint output in the latest docker image analysiscenter1/ds-py3.
A lot of
missing-function-docstring
andabstract-method
warnings happened inbatchflow/models/torch
folder we cant fix, because they occur on the torch side. They are fixing this and this.So we can:
torch
folder only like its currently done.@roman-kh