Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use custom delim in name generator #12

Closed
gegaryfa opened this issue Feb 13, 2024 · 2 comments · Fixed by #13
Closed

Use custom delim in name generator #12

gegaryfa opened this issue Feb 13, 2024 · 2 comments · Fixed by #13
Assignees
@gegaryfa

Comments

@gegaryfa
Copy link
Contributor

gegaryfa commented Feb 13, 2024 •
edited
Loading

Hello, I've spotted a bug where you cannot change the default delim for the name generator.
I will send over a PR soon
@gegaryfa gegaryfa changed the title Cannot open a pr Use custom delim in name generator Feb 13, 2024
@gegaryfa gegaryfa mentioned this issue Feb 13, 2024
Merged
@gegaryfa
Copy link
Contributor Author

@anandvarma is it possible to create a new release that contains this fix ?

@anandvarma
Copy link
Owner

Sure. Created a patch release 1.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gegaryfa gegaryfa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use the defined delim for namegen instead of the hardcoded "-" gegaryfa/namegen
2 participants
@anandvarma @gegaryfa