Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gatsby 5 Peer Dependency Support? #1018

Closed
2 tasks done
broksonic21 opened this issue Nov 22, 2022 · 3 comments
Closed
2 tasks done

Gatsby 5 Peer Dependency Support? #1018

broksonic21 opened this issue Nov 22, 2022 · 3 comments

Comments

@broksonic21
Copy link

Verify if it is a postcss bug
First verify that gatsby-plugin-purgecss is working by setting the option printRejected: true which will print out the list of removed selectors.
If the plugin is working, but the css is not getting purged as you would have hoped then it's very likely a purgecss issue. File for purgecss related bugs here https://github.com/FullHuman/purgecss/issues.

  • I have verified that this is not a purgecss issue.

Describe the bug
Gatsby 5 is out, but gatsby-plugin-purgecss only supports gatsby@"^2.0.0 || ^3.0.0 || ^4.0.0"

To Reproduce
Sample package.json to repro:

  "name": "test",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "author": "",
  "license": "ISC",
  "dependencies": {
    "gatsby-plugin-purgecss": "^6.1.2",
    "gatsby": "^5.1.0"
  }
}

Error with npm:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: test@1.0.0
npm ERR! Found: gatsby@5.1.0
npm ERR! node_modules/gatsby
npm ERR!   gatsby@"^5.1.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer gatsby@"^2.0.0 || ^3.0.0 || ^4.0.0" from gatsby-plugin-purgecss@6.1.2
npm ERR! node_modules/gatsby-plugin-purgecss
npm ERR!   gatsby-plugin-purgecss@"^6.1.2" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Configs

  • I have removed all personal information.

Expected behavior
Support latest gatsby version as a peer dependency

Additional information
n/a

@anantoghosh
Copy link
Owner

I'll update it soon.

@HKdAlex
Copy link

HKdAlex commented Dec 2, 2022

What be really great, thank you!

@anantoghosh
Copy link
Owner

Released in v6.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants