Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php support #3

Closed
m1ga opened this issue May 13, 2014 · 4 comments
Closed

php support #3

m1ga opened this issue May 13, 2014 · 4 comments

Comments

@m1ga
Copy link

m1ga commented May 13, 2014

PHP support would be nice

@Glavin001
Copy link

@m1ga , have you seen https://github.com/sdwood/php-beautifier ?

I am also making a fork of this, atom-beautifier, because it looks like the author is no longer contributing. Let me know if you're still interested in PHP support and maybe I'll add it to atom-beautifier-plus.

I am moving to atom-beautify.

@m1ga
Copy link
Author

m1ga commented Jun 13, 2014

I like the settings you can set in this beautifier (indent size, max preserved newlines,...). The other beautifier don't have these options and the php-beaufifier isnt't working but there is alreay an open bug for the problem.

@Glavin001
Copy link

I liked the settings in at the Atom packages settings panel, however, I the atom-beautify uses a .jsbeautifyrc file for configuration, meaning that it is persistent throughout your projects (can be saved and committed).

That is the reason I liked atom-beautifier. Maybe I will make a PR tonight to add that feature. Anything else that you like from atom-beautifier that atom-beautify does not have, @m1ga ?

@m1ga
Copy link
Author

m1ga commented Jun 14, 2014

nice! I think I can live without the settingspanel :) Looks like all settings are supported so it'll behave the same. Thanks. It doesn't fix the php problem here but it may be come to atom-beautify then or I'll use an extra package for that if the bug gets fixed in php-beautifier

@m1ga m1ga closed this as completed Jun 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants