Add group_member resource #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently waiting on a bug fix in the CLI where users who are not in the group being managed (e.g. administrators/owners) may encounter problems managing the members of that group. See https://discussions.agilebits.com/discussion/comment/565941 for the conversation. |
taiidani
force-pushed
the
feature/GroupMemberResource
branch
3 times, most recently
from
7a20b1d
to
72ef91e
Compare
|
Bug fix has been applied in 1.4.0. Updated this PR to have that as a required version. |
taiidani
force-pushed
the
feature/GroupMemberResource
branch
from
72ef91e
to
94b1d46
Compare
|
Thanks @taiidani |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44
Proposed Changes
onepassword_group_memberresource for managing group membership within a 1Password installation.opclient to 1.4.0 so that it receives the bug fixes applied to that version. In testing I also found that the automatic installation will not work on Mac due to their versions being distributed in a.pkginstaller; I added error handling to more cleanly instruct the user in that case.TODO
importbut doesn't use the hyphenated syntax