-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loader states #27
Comments
Hi @TheGooner93. Thank you, glad you liked it! I'm not sure what it's actually for, nor have I ever seen this pattern being used in any of the libraries that are implementing form inputs (including toggle switch). I can see two possible use cases where
Let me know what you think! |
Yeah what I'm thinking of is your point regarding integration with an API. Suppose toggling this switch is not being used as part of a form, but as a standalone input to perform an action ( for eg. adding a product to a wishlist in an ecommerce website) then a loading state would be sensible. The loading state within the input(as opposed to an entire page loading) would be definitely optional and nice to have. Feels like better UX too imo |
I see. In this case, I would use another best practice, optimistic UI. Think of a "Like" button on Twitter, when you click on it, it will animate immediately and then if something goes wrong, it will just restore itself to the original state and show some sort of toast with an error message. |
Yes exactly. I do have a PR ready for this. I will update once I fix the snapshot tests. |
Well, PR is unnecessary here. When implementing optimistic UI you can, for example, set |
Ah I see what you mean. Lets close this issue then |
Hi, this is great work.
I think it would be a great idea to also incorporate a
isLoading
prop to control any loading states? Wdyt @anatoliygatt ?The text was updated successfully, but these errors were encountered: