Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command line updater #66

Merged
merged 11 commits into from Jul 1, 2021
Merged

Command line updater #66

merged 11 commits into from Jul 1, 2021

Conversation

MattiDragon
Copy link
Contributor

Key features

  • Download files from directly modrinth api
  • Automatic picker for best version

Key concerns

  • Can't be used inside a IDE since it requires a jar to be present
  • Crashes with a uncaught exception if anything is wrong
  • Use gradle shadow plugin to shadow gson
  • Due to using the gradle shadow plugin the main jar is now GuessWhatWillHappenInThis-1.2.0-all.jar

PS. I also added a option to make all blocks slippery

@ENDERZOMBI102
Copy link
Collaborator

why do you shadow gson? minecraft alredy uses it. its already in the enviroment...

@MattiDragon
Copy link
Contributor Author

why do you shadow gson? minecraft alredy uses it. its already in the enviroment...

The updater runs in the command line. All I have is the mod jar and the jdk. I can't even use the include feature of loom + floader because I run without them.

@ENDERZOMBI102
Copy link
Collaborator

ENDERZOMBI102 commented Jun 26, 2021

just doing implementation should work then?
probably i'm just being dumb

@MattiDragon
Copy link
Contributor Author

Implementation means it's compiled and run with the dependecy. It doesn't mean that it's included in the final jar

@ENDERZOMBI102
Copy link
Collaborator

Implementation means it's compiled and run with the dependecy. It doesn't mean that it's included in the final jar

ohhhh right, i forgot that...

@anatom3000 anatom3000 merged commit 8347cbb into anatom3000:master Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants