This repository has been archived by the owner on Dec 31, 2020. It is now read-only.
Add a validation for the movie's imdbId #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a missing validation to get a movie's imdbId. It was only checking if there was an anchor with a href attribute, but not if the href attribute contained 'imdb'. So if there was no imdb anchor, the regex was still called, but on an undefined value. Update the tests movies to work, since the movies in the tests are no longer in theaters (may need to find a permanent solution). Added 2 tests to test the 2 validations : theathers not found & movie not found.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a missing validation to get a movie's imdbId. It was only checking if there was an anchor with a href attribute, but not if the href attribute contained 'imdb'. So if there was no imdb anchor, the regex was still called, but on an undefined value.
Update the tests movies to work, since the movies in the tests are no longer in theaters (may need to find a permanent solution).
Added 2 tests to test the 2 validations : theathers not found & movie not found.