Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: plugin incorrect requires semicolons #115

Closed
webbertakken opened this issue Apr 28, 2023 · 5 comments
Closed

Bug: plugin incorrect requires semicolons #115

webbertakken opened this issue Apr 28, 2023 · 5 comments
Assignees
Labels
bug Something isn't working clone

Comments

@webbertakken
Copy link

Consider the following correct syntax of firebase storage rules:

image

The plugin marks it as incorrect because it's picky about having semicolons.

image

How to reproduce:

Open the editor on Windows 11, WebStorm 2023.1, Plugin 2023.4.1 and paste the following in a file called storage.rules.

rules_version = '2';
service firebase.storage {
  match /b/{bucket}/o {
    match /{allPaths=**} {
      allow read, write: if false
    }

    match /users/{userId}/songs/{songId}/parts/{partId} {
      allow read: if userId == request.auth.uid
      allow write: if userId == request.auth.uid
        && request.resource.size < 8 * 1024 * 1024
        && request.resource.contentType.matches('audio/.*')
    }
  }
}
@github-actions github-actions bot added the clone label Apr 28, 2023
@dalgarins
Copy link
Contributor

@dalgarins dalgarins self-assigned this Apr 28, 2023
@dalgarins dalgarins added the bug Something isn't working label Apr 28, 2023
@dalgarins
Copy link
Contributor

dalgarins commented Apr 28, 2023

Screenshot 2023-04-28 at 5 47 20 PM

thanks the fix will be available on next version: 2023.4.2

@dalgarins
Copy link
Contributor

@webbertakken the update is available.

@webbertakken
Copy link
Author

Thank you very much! Will test it ASAP.

@webbertakken
Copy link
Author

I can confirm that this now works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working clone
Projects
None yet
Development

No branches or pull requests

2 participants