Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax check shortcoming... +++ #24

Closed
akauppi opened this issue Dec 5, 2020 · 3 comments · Fixed by #27
Closed

Syntax check shortcoming... +++ #24

akauppi opened this issue Dec 5, 2020 · 3 comments · Fixed by #27
Assignees

Comments

@akauppi
Copy link

akauppi commented Dec 5, 2020

First, it's very nice you have brought an IntelliJ plugin for Firebase security rules to existence. Thank You!

The real benefit from such would be in complex rules, highlighting rule syntax problems. Unfortunately, this is where my 2s test already failed:

      allow create: if isSignedIn() +++

The plugin does not mark the (added) +++ as a breach of syntax. Surely, it is...

For being able to truly put one's weight on such a plugin, would it be possible to bring Firebase authors in the loop, to help make it more aligned with the real rules language.

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.76. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@dalgarins dalgarins self-assigned this Dec 13, 2020
@dalgarins dalgarins linked a pull request Dec 13, 2020 that will close this issue
@dalgarins
Copy link
Contributor

Screen Shot 2020-12-13 at 12 27 07 AM

@dalgarins
Copy link
Contributor

Thanks for testing, issue will be fixed on version: 2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants