Not removing all software

[shadownetdev1]

It is my understanding that an uninstaller is suppose to remove its software, so shouldn't ppa-purge be removed after it does it's job on lines 92 & 93?

[morphis]

@shadownetdev1 this is tricky. We would need to record if ppa-purge was already installed before the installer was executed the first time as otherwise we do something the user doesn't expect from us as he installed ppa-purge on his own rather than we did it. Another option would be that we ship ppa-purge in the snap and don't require its installation at all.

[shadownetdev1]

@morphis My suggestion would be to check for an output from which. It is installed on all Ubuntu distros and to the best of my knowledge most Linux distros

It should be something like this:

   if [ -e /etc/apt/sources.list.d/morphis-ubuntu-anbox-support-xenial.list ]; then
           if command -v ppa-purge >/dev/null 2>&1; then
                 sudo ppa-purge ppa:morphis/anbox-support
           else
                 sudo apt install -y ppa-purge
                 sudo ppa-purge ppa:morphis/anbox-support
                 sudo apt remove -y ppa-purge
           fi
   fi

[shadownetdev1]

@morphis Updated my comment

[morphis]

@shadownetdev1 Can you propose this as PR?

[morphis]

This is now solved in master.